Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a process for working groups #13162

Merged
merged 4 commits into from
May 3, 2024
Merged

Conversation

alice-i-cecile
Copy link
Member

Objective

Coordinating work can be hard, and figuring out how to get started with contributions is always a challenge.

We've had great success with informal working groups in the past (primitives, bevy_color, stageless). However, they're not at all discoverable, are hard to keep track of and tend to flood the dev channels that they're in.

When their messages are moved to Discord threads, they then get completely scattered and buried.

Solution

We can formalize the working groups in a very process-light way, and give them a discoverable home by using a curated forum channel on Discord.

While we'll still need more stringent PR reviews for particularly complex or architectural changes made as part of these initiatives, a broad sign off on the course of action goes a long way to building consensus. By baking that into the process, I think we can avoid a lot of wasted work and relitigation without encouraging mega-PRs or RFCs.

@alice-i-cecile alice-i-cecile changed the title Initial draft on working groups Add a process for working groups May 1, 2024
@alice-i-cecile alice-i-cecile added C-Enhancement A new feature A-Meta About the project itself X-Controversial There is active debate or serious implications around merging this PR C-Needs-Release-Note Work that should be called out in the blog due to impact labels May 1, 2024
Copy link
Contributor

@NiseVoid NiseVoid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like a solid proposal, I especially like the part of SMEs/maintainers staying patient and supportive until the design doc is made. Getting large backlash immediately from someone with some level of authority would be hugely demotivating, especially considering the rust community has a habit of rejecting every new feature due to perceived costs (compile time, runtime performance, complexity, maintainance workload, etc).

@NthTensor
Copy link
Contributor

NthTensor commented May 1, 2024

This adds much-needed clarity and organization to a process that has been happening informally for ages. I think the way it's drawn up here is great. We also might want to make up a design-doc template at some point.

Copy link
Contributor

@Jondolf Jondolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this. Similar informal working groups have been very effective in the past, and I think formalizing them will help significantly in coordinating work as well as making everything more discoverable and easier to track. I mostly have just a few language nits

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Joona Aalto <jondolf.dev@gmail.com>
Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! Just one thought / suggestion.

CONTRIBUTING.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ItsDoot ItsDoot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my favorite organizational idea do far.

@alice-i-cecile alice-i-cecile requested a review from cart May 1, 2024 22:02
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 1, 2024
@alice-i-cecile
Copy link
Member Author

@cart I've added a section for the initial check as you requested. I think it's a reasonable idea, as long as we can keep the process light and turnaround fast.

When you're happy with this, feel free to merge.

@cart
Copy link
Member

cart commented May 1, 2024

@cart I've added a section for the initial check as you requested. I think it's a reasonable idea, as long as we can keep the process light and turnaround fast.
When you're happy with this, feel free to merge.

Awesome thanks! I'm happy with it. Lets give it a day or so to receive a few more eyes and then I'll merge if nothing else comes up.

@mweatherley
Copy link
Contributor

I'm quite happy with this, and I think that if it gains traction it could be a huge boon for the ecosystem. I especially like that the document focuses on this as a means of onboarding new contributors, which I regard as quite important.

Copy link
Member

@MrGVSV MrGVSV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it! I think this can definitely help with a huge problem: is the thing I want to implement even going to be accepted? Getting the consensus approval right at the start should hopefully keep motivation high and encourage others to contribute to the initiative.

CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@alice-i-cecile alice-i-cecile added X-Blessed Has a large architectural impact or tradeoffs, but the design has been endorsed by decision makers and removed X-Controversial There is active debate or serious implications around merging this PR labels May 2, 2024
Copy link
Member

@aevyrie aevyrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a fantastic process change that will address some of my current pain points with contribution and upstreaming. Thank you!

@cart cart added this pull request to the merge queue May 3, 2024
@lee-orr
Copy link
Contributor

lee-orr commented May 3, 2024

I think this would work really well even for things with a single code contributor if they are large enough - having a cohesive place for something like the #11426 PR would likely have helped keep track of things more easily.

Merged via the queue into bevyengine:main with commit 64c1c65 May 3, 2024
28 checks passed
@alice-i-cecile
Copy link
Member Author

Thank you to everyone involved with the authoring or reviewing of this PR! This work is relatively important and needs release notes! Head over to bevyengine/bevy-website#1309 if you'd like to help out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Meta About the project itself C-Enhancement A new feature C-Needs-Release-Note Work that should be called out in the blog due to impact S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Blessed Has a large architectural impact or tradeoffs, but the design has been endorsed by decision makers
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet