Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom_loop example to include plugin finalization #13215

Merged
merged 1 commit into from
May 3, 2024

Conversation

philpax
Copy link
Contributor

@philpax philpax commented May 3, 2024

Objective

The custom_loop example didn't replicate the app.finish / app.cleanup calls from the default runner; I discovered this when trying to troubleshoot why my application with a custom loop wasn't calling its plugin finalizers, and realised that the upstream example that I'd referenced didn't have the relevant calls.

Solution

Added the missing calls, replicating what the default runner does:

app.finish();
app.cleanup();

Testing

I've confirmed that adding these two calls to my application fixed the issue I was encountering. I haven't tested it within the example itself as it's relatively straightforward and I didn't want to pollute the example with a plugin using a finalizer.

Copy link
Contributor

github-actions bot commented May 3, 2024

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

@alice-i-cecile alice-i-cecile added this to the 0.14 milestone May 3, 2024
@alice-i-cecile alice-i-cecile added C-Examples An addition or correction to our examples A-App Bevy apps and plugins D-Straightforward Simple bug fixes and API improvements, docs, test and examples C-Bug An unexpected or incorrect behavior X-Uncontroversial This work is generally agreed upon labels May 3, 2024
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 3, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 3, 2024
Merged via the queue into bevyengine:main with commit 99b4fb6 May 3, 2024
28 checks passed
@philpax philpax deleted the patch-1 branch May 3, 2024 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-App Bevy apps and plugins C-Bug An unexpected or incorrect behavior C-Examples An addition or correction to our examples D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it X-Uncontroversial This work is generally agreed upon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants