Fix custom_loop
example to include plugin finalization
#13215
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The
custom_loop
example didn't replicate theapp.finish
/app.cleanup
calls from the default runner; I discovered this when trying to troubleshoot why my application with a custom loop wasn't calling its plugin finalizers, and realised that the upstream example that I'd referenced didn't have the relevant calls.Solution
Added the missing calls, replicating what the default runner does:
bevy/crates/bevy_app/src/app.rs
Lines 895 to 896 in d390420
Testing
I've confirmed that adding these two calls to my application fixed the issue I was encountering. I haven't tested it within the example itself as it's relatively straightforward and I didn't want to pollute the example with a plugin using a finalizer.