Support operations for render layers and fix equality comparisons #13310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoJoJet
commented
May 10, 2024
Comment on lines
120
to
126
| pub const fn and(self, other: Self) -> Self { | ||
| let mask = self.0 & other.0; | ||
| Self(mask) | ||
| } | ||
|
|
||
| /// Returns all [layers](Layer) included in either instance of [`RenderLayers`]. | ||
| pub const fn or(self, other: Self) -> Self { |
There was a problem hiding this comment.
I considered calling these intersection and union for clarity, but I wasn't sure what to call xor using that naming convention
There was a problem hiding this comment.
This would be the symmetric difference or disjunctive union. Pretty obscure so not sure it's worth switching. Note that Python does have a symmetric difference operation on sets. https://en.m.wikipedia.org/wiki/Symmetric_difference
There was a problem hiding this comment.
It probably is worth switching, at least to avoid potential confusion with the and method. I imagine some people may think a.and(b) means "all the layers from a and b"
james7132
approved these changes
May 13, 2024
james7132
added
A-Rendering
|
if we can do #13317 would mean these can't be const, not sure how const-ness affects their value for you |
kristoff3r
approved these changes
Jun 18, 2024
janhohenheim
added
the
S-Ready-For-Final-Review
JoJoJet
changed the title
tychedelia
approved these changes
Jun 30, 2024
There was a problem hiding this comment.
Thanks! The bug you identify in without potentially should make this included in 0.14 imo cc: @alice-i-cecile.
mockersf
pushed a commit
that referenced
this pull request
Jul 2, 2024
…3310) # Objective Allow combining render layers with a more-ergonomic syntax than `RenderLayers::from_iter(a.iter().chain(b.iter()))`. ## Solution Add the `or` operation (and corresponding `const` method) to allow computing the union of a set of render layers. While we're here, also added `and` and `xor` operations. Someone might find them useful ## Testing Added a simple unit test.
zmbush
pushed a commit
to zmbush/bevy
that referenced
this pull request
Jul 3, 2024
…vyengine#13310) # Objective Allow combining render layers with a more-ergonomic syntax than `RenderLayers::from_iter(a.iter().chain(b.iter()))`. ## Solution Add the `or` operation (and corresponding `const` method) to allow computing the union of a set of render layers. While we're here, also added `and` and `xor` operations. Someone might find them useful ## Testing Added a simple unit test.
MrGVSV
pushed a commit
to MrGVSV/bevy
that referenced
this pull request
Jul 5, 2024
…vyengine#13310) # Objective Allow combining render layers with a more-ergonomic syntax than `RenderLayers::from_iter(a.iter().chain(b.iter()))`. ## Solution Add the `or` operation (and corresponding `const` method) to allow computing the union of a set of render layers. While we're here, also added `and` and `xor` operations. Someone might find them useful ## Testing Added a simple unit test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Allow combining render layers with a more-ergonomic syntax than
RenderLayers::from_iter(a.iter().chain(b.iter())).Solution
Add the
oroperation (and correspondingconstmethod) to allow computing the union of a set of render layers. While we're here, also addedandandxoroperations. Someone might find them usefulTesting
Added a simple unit test.