Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Support calculating normals for indexed meshes" (#12716) and add support for calculating smooth normals #13333

Merged
merged 1 commit into from
May 16, 2024

Commits on May 14, 2024

  1. Revert "Support calculating normals for indexed meshes" (#12716)

    # Objective
    
    - Refactor the changes merged in #11654 to compute flat normals for
    indexed meshes instead of smooth normals.
    
    ## Solution
    
    - Partially revert the changes in #11654 to compute flat normals for
    both indexed and unindexed meshes in `compute_flat_normals`
    - Create a new method, `compute_smooth_normals`, that computes smooth
    normals for indexed meshes
    - Create a new method, `compute_normals`, that computes smooth normals
    for indexed meshes and flat normals for unindexed meshes by default. Use
    this new method instead of `compute_flat_normals`.
    
    ## Testing
    
    - Run the example with and without the changes to ensure that the
    results are identical.
    adithramachandran committed May 14, 2024
    Configuration menu
    Copy the full SHA
    968f051 View commit details
    Browse the repository at this point in the history