Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc for Added, Changed #13458

Merged
merged 5 commits into from
May 21, 2024
Merged

Fix doc for Added, Changed #13458

merged 5 commits into from
May 21, 2024

Conversation

SpecificProtagonist
Copy link
Contributor

@SpecificProtagonist SpecificProtagonist commented May 21, 2024 •
edited

Objective

Fixes #13426

Solution

Correct documentation to describe current behavior

@alice-i-cecile
Copy link
Member

Question: Should this also include an explicit note that this includes changes from bevore the system was first run?

I think this would be slightly better yes. We should also make sure to update the is_added and is_changed methods too.

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-ECS Entities, components, systems, and events S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels May 21, 2024
@alice-i-cecile alice-i-cecile added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels May 21, 2024
auto-merge was automatically disabled May 21, 2024 19:11

Head branch was pushed to by a user without write access

@SpecificProtagonist
Copy link
Contributor Author

Also added a note to Tick as a bunch of places refer to the last time a system has run without being clear about what happens when the system hasn't been run.

@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 21, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 21, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue May 21, 2024
Merged via the queue into bevyengine:main with commit 6c95d54 May 21, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

False positives for Added/Changed on first system run
2 participants
@SpecificProtagonist @alice-i-cecile