Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds back in way to convert color to u8 array, implemented for the two RGB color types, also renames Color::linear to Color::to_linear as discussed on discord. #13739

Closed
wants to merge 5 commits into from
Closed

Adds back in way to convert color to u8 array, implemented for the two RGB color types, also renames Color::linear to Color::to_linear as discussed on discord. #13739

wants to merge 5 commits into from

Commits on Jun 7, 2024

  1. Rename Color::linear to Color::to_linear, added Color::to_srgba as th… 

    …e other major option. Added to_u8_array, from_u8_array and _no_alpha versions of them to ColorToComponent, implemented for SRgba and LinearRgba and left unimplemented! for other color types which don't make sense. Removed redundant extra version of to_f32_array in LinearRgba and added use ColorToComponent where that was used in other code, some extra tidy up of usage to use these new functions.
    @gagnus
    gagnus committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    99be344 View commit details
    Browse the repository at this point in the history

  2. round float before converting to u8 to to_u8_array

    @gagnus
    gagnus committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    38d62ac View commit details
    Browse the repository at this point in the history

  3. Merge branch 'main' into main

    @gagnus
    gagnus authored Jun 7, 2024
    Configuration menu
    Copy the full SHA
    c47129f View commit details
    Browse the repository at this point in the history

  4. cargo fmt

    @gagnus
    gagnus committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    32c0dc4 View commit details
    Browse the repository at this point in the history

  5. New trait ColorToPacked for the u8 conversion functions, means all th… 

    …e other color types dont need unimplemented versions.
    @gagnus
    gagnus committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    5207210 View commit details
    Browse the repository at this point in the history