[Merged by Bors] - Fix pipeline initialisation of wireframe mode (fixes #1609) #1623
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More details are in the associated issue #1609.
While looking for the source of this issue, I've noticed that the
set
andset_untracked
methods aren't really DRY:bevy/crates/bevy_asset/src/assets.rs
Lines 76 to 85 in 6860693
bevy/crates/bevy_asset/src/assets.rs
Lines 91 to 99 in 6860693
Shouldn't
set
callset_untracked
? Also, given the bug that arose from a misusage of these functions, maybe some refactoring is needed?