[Merged by Bors] - Fix pipeline initialisation of wireframe mode (fixes #1609)

[simgt]

More details are in the associated issue #1609.

While looking for the source of this issue, I've noticed that the set and set_untracked methods aren't really DRY:

bevy/crates/bevy_asset/src/assets.rs

Lines 76 to 85 in 6860693

	let id: HandleId = handle.into();
	if self.assets.insert(id, asset).is_some() {
	self.events.send(AssetEvent::Modified {
	handle: Handle::weak(id),
	});
	} else {
	self.events.send(AssetEvent::Created {
	handle: Handle::weak(id),
	});
	}

bevy/crates/bevy_asset/src/assets.rs

Lines 91 to 99 in 6860693

	let id: HandleId = handle.into();
	if self.assets.insert(id, asset).is_some() {
	self.events.send(AssetEvent::Modified {
	handle: Handle::weak(id),
	});
	} else {
	self.events.send(AssetEvent::Created {
	handle: Handle::weak(id),
	});

Shouldn't set call set_untracked? Also, given the bug that arose from a misusage of these functions, maybe some refactoring is needed?

[jakobhellermann]

The other pipelines use set_untracked as well:

bevy/crates/bevy_pbr/src/render_graph/mod.rs

Line 58 in 3a2a688

pipelines.set_untracked(FORWARD_PIPELINE_HANDLE, forward_pipeline);

bevy/crates/bevy_sprite/src/render/mod.rs

Line 162 in 2b0a48d

pipelines.set_untracked(SPRITE_PIPELINE_HANDLE, build_sprite_pipeline(shaders));

I think the PR is ready for cart™

[cart]

This is the right fix. Thanks!

While looking for the source of this issue, I've noticed that the set and set_untracked methods aren't really DRY:

Yeah set could call set_untracked. That would be a welcome change.

[cart]

bors r+

[bors]

Pull request successfully merged into main.

Build succeeded:

• build-android
• build (nightly, ubuntu-latest)
• build (stable, macos-latest)
• build (stable, ubuntu-latest)
• build (stable, windows-latest)
• build-wasm (nightly, ubuntu-latest)
• build-wasm (stable, ubuntu-latest)
• markdownlint