[Merged by Bors] - bevy_render2: Make default near plane more sensible at 0.1 #2703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 tasks
I would argue that especially for VR a better default would be 0.01m (1cm). Even if you can't focus that close you would probably notice objects clipping if put near the face. |
|
Yup I buy that. This is an indisputable improvement over the current situation so I think ill just merge it now. But I'm happy to discuss alternative defaults. Its worth looking into what other engines default to as well. Godot defaults to 0.05. |
|
bors + |
|
Did you mean "r+"? |
|
Yes bors thank you :) |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Aug 23, 2021
# Objective The default perspective projection near plane being at 1 unit feels very far away if one considers units to directly map to real world units such as metres. Not being able to see anything that is closer than 1m is unnecessarily limiting. Using a default of 0.1 makes more sense as it is difficult to even focus on things closer than 10cm in the real world. ## Solution - Changed the default perspective projection near plane to 0.1.
|
Pull request successfully merged into pipelined-rendering. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
The default perspective projection near plane being at 1 unit feels very far away if one considers units to directly map to real world units such as metres. Not being able to see anything that is closer than 1m is unnecessarily limiting. Using a default of 0.1 makes more sense as it is difficult to even focus on things closer than 10cm in the real world.
Solution