[Merged by Bors] - Fix release builds: Move asserts under #[cfg(debug_assertions)] #4871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alice-i-cecile
added
C-Bug
|
Fixes the failure introduced by #4723. |
alice-i-cecile
approved these changes
May 30, 2022
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
May 30, 2022
# Objective `debug_assert!` macros must still compile properly in release mode due to how they're implemented. This is causing release builds to fail. ## Solution Change them to `assert!` macros inside `#[cfg(debug_assertions)]` blocks.
bors
bot
changed the title
james7132
added a commit
to james7132/bevy
that referenced
this pull request
Jun 7, 2022
…engine#4871) # Objective `debug_assert!` macros must still compile properly in release mode due to how they're implemented. This is causing release builds to fail. ## Solution Change them to `assert!` macros inside `#[cfg(debug_assertions)]` blocks.
ItsDoot
pushed a commit
to ItsDoot/bevy
that referenced
this pull request
Feb 1, 2023
…engine#4871) # Objective `debug_assert!` macros must still compile properly in release mode due to how they're implemented. This is causing release builds to fail. ## Solution Change them to `assert!` macros inside `#[cfg(debug_assertions)]` blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
debug_assert!macros must still compile properly in release mode due to how they're implemented. This is causing release builds to fail.Solution
Change them to
assert!macros inside#[cfg(debug_assertions)]blocks.