Fix FloatOrd hash being different for different NaN values #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think NaN and zeroes are the only two cases where float equality is different to byte equality (Going by https://en.wikipedia.org/wiki/IEEE_754-1985#Comparing_floating-point_numbers). It wouldn't surprise me to learn of more weird edge cases though... |
|
yeah floats are wild. in this case, im totally cool with iteratively improving as more differences are discovered. |
karroffel
added
the
C-Code-Quality
mrk-its
pushed a commit
to mrk-its/bevy
that referenced
this pull request
Oct 6, 2020
…e#618) * Fix FloatOrd hash being different for different NaN values * Fix FloatOrd hashing +0.0 and -0.0 to different values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are multiple representations of
NaNpossible. TheEqimpl treats them as equal, so theHashimpl should hash them to the same value as well.