Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - Call mesh2d_tangent_local_to_world with the right arguments #6209

Closed
wants to merge 1 commit into from

Conversation

CatThingy
Copy link
Contributor

Objective

Allow Mesh2d shaders to work with meshes that have vertex tangents

Solution

Correctly pass mesh.model into mesh2d_tangent_local_to_world

@alice-i-cecile alice-i-cecile added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Oct 9, 2022
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Oct 9, 2022
@superdump
Copy link
Contributor

bors r+

bors bot pushed a commit that referenced this pull request Oct 9, 2022
# Objective

Allow `Mesh2d` shaders to work with meshes that have vertex tangents
## Solution

Correctly pass `mesh.model` into `mesh2d_tangent_local_to_world`
@bors bors bot changed the title Call mesh2d_tangent_local_to_world with the right arguments [Merged by Bors] - Call mesh2d_tangent_local_to_world with the right arguments Oct 9, 2022
@bors bors bot closed this Oct 9, 2022
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 19, 2022
…gine#6209)

# Objective

Allow `Mesh2d` shaders to work with meshes that have vertex tangents
## Solution

Correctly pass `mesh.model` into `mesh2d_tangent_local_to_world`
james7132 pushed a commit to james7132/bevy that referenced this pull request Oct 28, 2022
…gine#6209)

# Objective

Allow `Mesh2d` shaders to work with meshes that have vertex tangents
## Solution

Correctly pass `mesh.model` into `mesh2d_tangent_local_to_world`
Pietrek14 pushed a commit to Pietrek14/bevy that referenced this pull request Dec 17, 2022
…gine#6209)

# Objective

Allow `Mesh2d` shaders to work with meshes that have vertex tangents
## Solution

Correctly pass `mesh.model` into `mesh2d_tangent_local_to_world`
ItsDoot pushed a commit to ItsDoot/bevy that referenced this pull request Feb 1, 2023
…gine#6209)

# Objective

Allow `Mesh2d` shaders to work with meshes that have vertex tangents
## Solution

Correctly pass `mesh.model` into `mesh2d_tangent_local_to_world`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants