Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't Fail On Non-Mappable Entities in Children #6791

Closed
wants to merge 1 commit into from

Conversation

zicklag
Copy link
Member

@zicklag zicklag commented Nov 29, 2022

Objective

Fixes #6790

Solution

  • Don't fail when mapping entities that aren't found in the EntityMap.

I don't think this requires a changelog entry, but let me know if I'm wrong.

Changelog

This section is optional. If this was a trivial fix, or has no externally-visible impact, you can delete this section.

  • What changed as a result of this PR?
  • If applicable, organize changes under "Added", "Changed", or "Fixed" sub-headings
  • Stick to one or two sentences. If more detail is needed for a particular change, consider adding it to the "Solution" section
    • If you can't summarize the work, your change may be unreasonably large / unrelated. Consider splitting your PR to make it easier to review and merge!

Migration Guide

This section is optional. If there are no breaking changes, you can delete this section.

  • If this PR is a breaking change (relative to the last release of Bevy), describe how a user might need to migrate their code to support these changes
  • Simply adding new functionality is not a breaking change.
  • Fixing behavior that was definitely a bug, rather than a questionable design choice is not a breaking change.

Copy link
Member

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This potentially makes an invalid hierarchy. This probably will panic when working with the propagation systems.

@zicklag
Copy link
Member Author

zicklag commented Nov 29, 2022

Looks like we need another solution then.

I'll close this PR, so discussion can be continued in the issue, and we can open a new PR if we come up with a different solution.

@zicklag zicklag closed this Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Hierarchy Parent-child entity hierarchies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReflectMapEntities on Children Component Fails to Complete with Partial EntityMap.
2 participants