[Merged by Bors] - Fix closing window does not exit app in desktop_app mode #7628
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Welcome, new contributor! Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨ |
alice-i-cecile
approved these changes
Feb 11, 2023
alice-i-cecile
added
C-Bug
hymm
approved these changes
Feb 13, 2023
|
Can you add |
hymm
added
the
S-Ready-For-Final-Review
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
# Objective - `close_when_requested` system needs to run before `exit_on_*` systems, otherwise it takes another loop to exit app. - Fixes #7624 ## Solution - Move `close_when_request` system to Update phase [as before](#7624 (comment)).
|
Build failed: |
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2023
# Objective - `close_when_requested` system needs to run before `exit_on_*` systems, otherwise it takes another loop to exit app. - Fixes #7624 ## Solution - Move `close_when_request` system to Update phase [as before](#7624 (comment)).
|
Pull request successfully merged into main. Build succeeded:
|
bors
bot
changed the title
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 14, 2023
…7628) # Objective - `close_when_requested` system needs to run before `exit_on_*` systems, otherwise it takes another loop to exit app. - Fixes bevyengine#7624 ## Solution - Move `close_when_request` system to Update phase [as before](bevyengine#7624 (comment)).
myreprise1
pushed a commit
to myreprise1/bevy
that referenced
this pull request
Feb 15, 2023
…7628) # Objective - `close_when_requested` system needs to run before `exit_on_*` systems, otherwise it takes another loop to exit app. - Fixes bevyengine#7624 ## Solution - Move `close_when_request` system to Update phase [as before](bevyengine#7624 (comment)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
close_when_requestedsystem needs to run beforeexit_on_*systems, otherwise it takes another loop to exit app.WinitSettings::desktop_app()causes App to keep running after closing window #7624Solution
close_when_requestsystem to Update phase as before.