Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ChangeTrackers #7902

Merged
merged 3 commits into from
Mar 9, 2023
Merged

Remove ChangeTrackers #7902

merged 3 commits into from
Mar 9, 2023

Conversation

james7132
Copy link
Member

Objective

ChangeTrackers is deprecated in 0.10, and should be removed in 0.11.

Solution

Remove it.

This PR is blocked on bumping the version number to at least 0.11.0-dev.

Changelog

Removed: ChangeTrackers has been removed. It was deprecated in 0.10.

Migration Guide

ChangeTrackers has been removed .Use Ref<T> queries instead.

@james7132 james7132 added A-ECS Entities, components, systems, and events S-Blocked This cannot move forward until something else changes S-Needs-Design-Doc This issue or PR is particularly complex, and needs an approved design doc before it can be merged and removed S-Needs-Design-Doc This issue or PR is particularly complex, and needs an approved design doc before it can be merged labels Mar 5, 2023
@james7132 james7132 added S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it and removed S-Blocked This cannot move forward until something else changes labels Mar 6, 2023
@JoJoJet JoJoJet added this to the 0.11 milestone Mar 6, 2023
@james7132 james7132 enabled auto-merge March 9, 2023 19:54
@james7132 james7132 added this pull request to the merge queue Mar 9, 2023
Merged via the queue into bevyengine:main with commit 7d9cb1c Mar 9, 2023
@james7132 james7132 added the C-Breaking-Change A breaking change to Bevy's public API that needs to be noted in a migration guide label Mar 9, 2023
@james7132 james7132 deleted the remove-change-trackers branch March 14, 2023 04:14
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@james7132 @Shfty
Remove ChangeTrackers (bevyengine#7902)
74469f5
Shfty pushed a commit to shfty-rust/bevy that referenced this pull request Mar 19, 2023
@james7132 @Shfty
Remove ChangeTrackers (bevyengine#7902)
769d089
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hymm hymm hymm approved these changes

@JoJoJet JoJoJet JoJoJet approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Breaking-Change A breaking change to Bevy's public API that needs to be noted in a migration guide S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.11
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@james7132 @hymm @JoJoJet