Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the UV calculations for clipped and flipped ImageNodes #8195

Merged
merged 3 commits into from Apr 17, 2023
Merged

Fix the UV calculations for clipped and flipped ImageNodes #8195

merged 3 commits into from Apr 17, 2023

Commits on Mar 24, 2023

  1. The flip_x and flip_y UiImage properties weren't working correc… 

    …tly when clipping was applied.

Instead of flipping the entire image, `prepare_ui_nodes` would only flip the clipped area.

With this change, whenever flip_x or flip_y is set the image rect coordinates are swapped and the clipping coords are inverted along the flipped axes before uvs are calculated.
    @ickshonpe
    ickshonpe committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    5c76870 View commit details
    Browse the repository at this point in the history

  2. fix for needless_range_loop ci lint

    @ickshonpe
    ickshonpe committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    0346764 View commit details
    Browse the repository at this point in the history

  3. cargo fmt

    @ickshonpe
    ickshonpe committed Mar 24, 2023
    Configuration menu
    Copy the full SHA
    8580351 View commit details
    Browse the repository at this point in the history