Fix the UV calculations for clipped and flipped ImageNodes #8195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly when clipping was applied. Instead of flipping the entire image, `prepare_ui_nodes` would only flip the clipped area. With this change, whenever flip_x or flip_y is set the image rect coordinates are swapped and the clipping coords are inverted along the flipped axes before uvs are calculated.
ickshonpe
changed the title
james7132
added
A-UI
james7132
approved these changes
Mar 31, 2023
james7132
added
the
S-Ready-For-Final-Review
Yes, I feel confident this works. At worst if there are any problems they'll be obvious in the displayed output. |
alice-i-cecile
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Instead of flipping the entire image,
prepare_ui_nodesonly flips the unclipped area.Solution
Whenever flip_x or flip_y is set swap the image rect coordinates and invert the clipping coords along the flipped axes before the UVs are calculated.
--
Changelog
prepare_uinodesso that the UVs for clipped and flipped image nodes are calculated correctly.