Update FileAssetIo NotFound error to include full path #821
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Moxinilian
added
A-Assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When learning bevy I ran into the issue loading an asset and I could not figure out where to place the asset in order for it to be found by "asset_server.load".
I believe multiple other people also have run into the same issues. Some people assume it should be rooted at the cargo project folder, some believe it might be rooted at the location of the built binary, but none expect that it's a folder called 'assets':
Examples of people potentially confused:
https://discordapp.com/channels/691052431525675048/742884593551802431/775146229880717322
Issue #810
https://discordapp.com/channels/691052431525675048/742884593551802431/775199619504144434
This updates FileAssetIo to include the full path in the error message, this will clearly flag to the developer that the game engine is looking for the assets specifically in this location. This should be enough information for people to resolve the issue by clarifying what the convention is.