Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export glam_assert feature #8232

Merged
merged 4 commits into from
Mar 28, 2023
Merged

Re-export glam_assert feature #8232

merged 4 commits into from
Mar 28, 2023

Conversation

ameknite
Copy link
Contributor

Objective

  • Allow the use of the "glam _assert" feature to help catch runtime errors and validate the arguments passed to glam.

e.g.

// Will panic if self is zero length when glam_assert is enabled.
    pub fn normalize(self) -> Self {
        let normalized = self.mul(self.length_recip());
        glam_assert!(normalized.is_finite());
        normalized
    }

Solution

  • Re-export the optional feature glam_assert

Changelog

Added: Optional feature "glam_assert"

Cargo.toml Outdated Show resolved Hide resolved
docs/cargo_features.md Outdated Show resolved Hide resolved
@james7132 james7132 added A-Math Fundamental domain-agnostic mathematical operations C-Feature A new feature, making something new possible labels Mar 28, 2023
@james7132 james7132 requested a review from mockersf March 28, 2023 19:46
@james7132 james7132 added this to the 0.11 milestone Mar 28, 2023
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Mar 28, 2023
@mockersf mockersf added this pull request to the merge queue Mar 28, 2023
Merged via the queue into bevyengine:main with commit bb63ad7 Mar 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Math Fundamental domain-agnostic mathematical operations C-Feature A new feature, making something new possible S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants