Remove unnecesssary values Vec from DynamicUniformBuffer and DynamicStorageBuffer #8299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james7132
added
A-Rendering
james7132
added
the
C-Breaking-Change
|
It looks like your PR is a breaking change, but you didn't provide a migration guide. Could you add some context on what users should update when this change get released in a new version of Bevy? |
|
This seems to show a rough ~12% improvement over
|
mockersf
approved these changes
Apr 4, 2023
superdump
approved these changes
Apr 4, 2023
superdump
pushed a commit
that referenced
this pull request
Apr 4, 2023
# Objective While working on #8299, I noticed that we're using a `capacity` field, even though `wgpu::Buffer` exposes a `size` accessor that does the same thing. ## Solution Remove it from all buffer wrappers. Use `wgpu::Buffer::size` instead. Default to 0 if no buffer has been allocated yet.
This was referenced Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #8284.
valuesis being pushed to separately from the actual scratch buffer inDynamicUniformBuffer::pushandDynamicStorageBuffer::push. In both types,valuesis really only used to track the number of elements being added to the buffer, yet is causing extra allocations, size increments and excess copies.Solution
Remove it and its remaining uses. Replace it with accesses to
scratchinstead.I removed the
lenaccessor, as it may be non-trivial to compute just fromscratch. If this is still desirable to have, we can keep alenmember field to track it instead of relying onscratch.