Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove capacity fields from all Buffer wrapper types #8301

Merged
merged 1 commit into from Apr 4, 2023
Merged

Remove capacity fields from all Buffer wrapper types #8301

merged 1 commit into from Apr 4, 2023

Conversation

james7132
Copy link
Member

@james7132 james7132 commented Apr 4, 2023 •
edited

Objective

While working on #8299, I noticed that we're using a capacity field, even though wgpu::Buffer exposes a size accessor that does the same thing.

Solution

Remove it from all buffer wrappers. Use wgpu::Buffer::size instead. Default to 0 if no buffer has been allocated yet.

@james7132 james7132 added A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change labels Apr 4, 2023
@james7132 james7132 added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label Apr 4, 2023
@superdump superdump added this pull request to the merge queue Apr 4, 2023
Merged via the queue into bevyengine:main with commit 21e1893 Apr 4, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superdump superdump superdump approved these changes

@JoJoJet JoJoJet JoJoJet approved these changes

@nicopap nicopap nicopap approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@james7132 @superdump @JoJoJet @nicopap