Make setup of Opaque3dPrepass and AlphaMask3dPrepass phase items consistent with others

[Sixmorphugus]

Objective

When browsing the bevy source code to try and learn about bevy_core_pipeline, I noticed that the DrawFunctions resources, sort_phase_systems and texture preparation for the Opaque3d and AlphaMask3d phase items are all set up in bevy_core_pipeline, while the Opaque3dPrepass and AlphaMask3dPrepass phase items are only declared in bevy_core_pipeline, and actually registered properly with the renderer in bevy_pbr.

This means that, if I am trying to make crate that replaces bevy_pbr, I need to make sure I manually fix this unfinished setup the same way that bevy_pbr does. Worse, it means that if I try to use the PrepassNode bevy_core_pipeline adds without fixing this, the engine will simply crash because the DrawFunctions<T> resources cannot be accessed.

The only advantage I can think of for bevy doing it this way is an ambiguous performance save due to the prepass render phases not being present unless you are using prepass materials with PBR.

Solution

I have moved the registration of DrawFunctions<T>, sort_phase_system::<T>, camera RenderPhase extraction, and texture preparation for prepass's phase items into bevy_core_pipeline alongside the equivalent code that sets up the Opaque3d, AlphaMask3d and Transparent3d phase items.

Am open to tweaking this to improve the performance impact of prepass things being around if the app doesn't use them if needed.

I've tested that the shader_prepass example still works with this change.

[github-actions]

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

[Sixmorphugus]

Fixing unused imports rn

[nicopap]

LGTM

[nicopap]

Actually, apply_normal_mapping is used in pbr_prepass.wgsl at line 98, you should update that file to use the new argument list.

The reason it compiles is that the shader_prepass.rs example doesn't have a normal map, so the #ifdef removes the code from the file, and there is no opportunity to create a shader compilation error since the code is never compiled.

[Sixmorphugus]

Actually, apply_normal_mapping is used in pbr_prepass.wgsl at line 98, you should update that file to use the new argument list.

The reason it compiles is that the shader_prepass.rs example doesn't have a normal map, so the #ifdef removes the code from the file, and there is no opportunity to create a shader compilation error since the code is never compiled.

I'm not sure what you mean, I've pulled changes just now and the argument list hasn't changed in pbr_functions.wgsl.
I also never touched any .wgsl files in these changes and am unsure why any would be affected.
What new argument list should it be using?

[nicopap]

I mistook this PR for #8106 😅 How embarrassing. Everything is good

[IceSentry]

LGTM, sorry for not reviewing this sooner.