Add UiRect::px() and UiRect::percent() utils
#8866
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two utility methods to make manipulating `UiRect` from code more concise: - `UiRect::px()` create a new `UiRect` like the `new()` function, but with values in logical pixels directly. - `UiRect::percent()` is similar, with values as percentages. This saves a lot of typing and makes UI code more compact while retaining readability.
djeedai
added
A-UI
Aceeri
approved these changes
Jun 17, 2023
djeedai
added
the
S-Ready-For-Final-Review
alice-i-cecile
approved these changes
Jun 19, 2023
james7132
pushed a commit
to james7132/bevy
that referenced
this pull request
Jun 19, 2023
# Objective Make the UI code more concise. ## Solution Add two utility methods to make manipulating `UiRect` from code more concise: - `UiRect::px()` create a new `UiRect` like the `new()` function, but with values in logical pixels directly. - `UiRect::percent()` is similar, with values as percentages. This saves a lot of typing and makes UI code more compact while retaining readability. --- ## Changelog ### Added Added two new constructors `UiRect::px()` and `UiRect::percent()` to create a new `UiRect` from values directly specified in logical pixels and percentages, respectively. The argument order is the same as `UiRect::new()`, but avoids having to repeat `Val::Px` and `Val::Percent`, respectively.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Make the UI code more concise.
Solution
Add two utility methods to make manipulating
UiRectfrom code more concise:UiRect::px()create a newUiRectlike thenew()function, but with values in logical pixels directly.UiRect::percent()is similar, with values as percentages.This saves a lot of typing and makes UI code more compact while retaining readability.
Changelog
Added
Added two new constructors
UiRect::px()andUiRect::percent()to create a newUiRectfrom values directly specified in logical pixels and percentages, respectively. The argument order is the same asUiRect::new(), but avoids having to repeatVal::PxandVal::Percent, respectively.