Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CAS shader with explicit FullscreenVertexOutput import #8993

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

cart
Copy link
Member

@cart cart commented Jun 29, 2023

Objective

Followup bugfix for #5703. Without this we get the following error when CAS (Contrast Adaptive Sharpening) is enabled:

2023-06-29T01:31:23.829331Z ERROR bevy_render::render_resource::pipeline_cache: failed to process shader:
error: unknown type: 'FullscreenVertexOutput'
   ┌─ crates/bevy_core_pipeline/src/contrast_adaptive_sharpening/robust_contrast_adaptive_sharpening.wgsl:63:17
   │
63 │ fn fragment(in: FullscreenVertexOutput) -> @location(0) vec4<f32> {
   │                 ^^^^^^^^^^^^^^^^^^^^^^ unknown type
   │
   = unknown type: 'FullscreenVertexOutput'

@robtfm I wouldn't expect this to fail. I was under the impression the #import bevy_core_pipeline::fullscreen_vertex_shader would pull "everything" from that file into this one?

@cart cart added C-Bug An unexpected or incorrect behavior A-Rendering Drawing game state to the screen labels Jun 29, 2023
@cart cart added this to the 0.11 milestone Jun 29, 2023
@robtfm
Copy link
Contributor

robtfm commented Jun 29, 2023

Items need to be either individually imported, or qualified at point of use. I didn’t do glob imports yet.

Copy link
Contributor

@Elabajaba Elabajaba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran into the same crash, and this fixed it.

@cart
Copy link
Member Author

cart commented Jun 29, 2023

Items need to be either individually imported, or qualified at point of use. I didn’t do glob imports yet.

Ah gotcha gotcha. Then this makes perfect sense!

@cart cart added this pull request to the merge queue Jun 29, 2023
Merged via the queue into bevyengine:main with commit bcf53b8 Jun 29, 2023
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen C-Bug An unexpected or incorrect behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants