Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos throughout the project #9090

Merged
merged 13 commits into from Jul 10, 2023
Merged

Fix typos throughout the project #9090

merged 13 commits into from Jul 10, 2023

Conversation

ClayenKitten
Copy link
Contributor

Objective

Fix typos throughout the project.

Solution

typos project was used for scanning, but no automatic corrections were applied. I checked everything by hand before fixing.

Most of the changes are documentation/comments corrections. Also, there are few trivial changes to code (variable name, pub(crate) function name and a few error/panic messages).

Unsolved

bevy_reflect_derive has typo in enum variant name that I didn't fix. Enum is pub(crate), so there shouldn't be any trouble if fixed. However, code is tightly coupled with macro usage, so I decided to leave it for more experienced contributor just in case.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 9, 2023

Welcome, new contributor!

Please make sure you've read our contributing guide and we look forward to reviewing your pull request shortly ✨

Copy link
Member

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fixes, thanks!

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation C-Code-Quality A section of code that is hard to understand or change S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it labels Jul 10, 2023
@alice-i-cecile
Copy link
Member

Can you please open an issue for the typo in the enum variant name?

@ClayenKitten
Copy link
Contributor Author

Can you please open an issue for the typo in the enum variant name?

On it!

@mockersf mockersf added this pull request to the merge queue Jul 10, 2023
Merged via the queue into bevyengine:main with commit ffc5727 Jul 10, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Code-Quality A section of code that is hard to understand or change C-Docs An addition or correction to our documentation S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants