Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify that wgpu is based on the webGPU API #9093

Merged
merged 1 commit into from Jul 14, 2023
Merged

Clarify that wgpu is based on the webGPU API #9093

merged 1 commit into from Jul 14, 2023

Conversation

ameknite
Copy link
Contributor

Objective

wgpu is not only inspired by Vulkan, so I think it's better to just mention that it's based on WebGPU

Solution

  • Change the description

@alice-i-cecile alice-i-cecile added C-Docs An addition or correction to our documentation A-Rendering Drawing game state to the screen labels Jul 10, 2023
@james7132 james7132 added the X-Controversial There is active debate or serious implications around merging this PR label Jul 10, 2023
@james7132
Copy link
Member

Marking as controversial due to its high visibility on the front-facing readme.

@fintelia
Copy link
Contributor

This is the description from the wgpu README:

wgpu is a cross-platform, safe, pure-rust graphics api. It runs natively on Vulkan, Metal, D3D12, D3D11, and OpenGLES; and on top of WebGPU on wasm.

The api is based on the WebGPU standard. It serves as the core of the WebGPU integration in Firefox, Servo, and Deno.

cart
cart approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@cart cart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup this is more descriptive!

@cart cart added this pull request to the merge queue Jul 13, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 13, 2023
@cart cart added this pull request to the merge queue Jul 14, 2023
Merged via the queue into bevyengine:main with commit ea41a43 Jul 14, 2023
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cart cart cart approved these changes

Assignees
No one assigned
Labels
A-Rendering Drawing game state to the screen C-Docs An addition or correction to our documentation X-Controversial There is active debate or serious implications around merging this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@ameknite @james7132 @fintelia @cart @alice-i-cecile