Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgpu: use mailbox instead of fifo for vsync #920

Merged
merged 1 commit into from
Nov 26, 2020
Merged

Conversation

cart
Copy link
Member

@cart cart commented Nov 23, 2020

This has lower latency (for the platforms that support it). It will fall back to Fifo for platforms that don't support it. Hopefully this will resolve the "input lag" problem for most people.

Its worth pointing out that this doesn't actually resolve the lag problem for me on linux/gnome-x11/nvidia gtx 1070/proprietary driver. Its possible that some aspect of that combination doesn't support "mailbox".

With that setup (and a 100fps monitor) i get 3 frames of lag.

If i disable vsync entirely, i get 1 frame of lag.

This resolved the lag problem for @zachreizner, who suggested this change in the first place.

@cart
Copy link
Member Author

cart commented Nov 23, 2020

@bjorn3 I'm curious if this fixes the lag problem for you (in part or in whole). If you find the time (and the motivation) to run another OBS test, let me know!

@cart cart added the A-Rendering Drawing game state to the screen label Nov 23, 2020
@cart cart merged commit 86d724e into bevyengine:master Nov 26, 2020
@fopsdev fopsdev mentioned this pull request Jan 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Rendering Drawing game state to the screen
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant