Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Last component of installation path set to Beyond-All-Reason on reinstall/update. #19

Closed
p2004a opened this issue Apr 16, 2023 · 3 comments
Closed

Last component of installation path set to Beyond-All-Reason on reinstall/update. #19

p2004a opened this issue Apr 16, 2023 · 3 comments
Assignees
@p2004a

Comments

@p2004a
Copy link
Collaborator

p2004a commented Apr 16, 2023 •
edited
Loading

When users selects during installation custom directory that doesn't exist e.g. C:\BAR, it is allowed, and the game is installed directly there. Unfortunately on update/reinstall installer correctly detects the install path but appends Beyond-All-Reason into the path, and users ends up with 2 installations, old one in C:\BAR and a new one inside that in C:\BAR\Beyond-All-Reason.

Steps to reproduce:

  1. Download old launcher
  2. Install in custom location, doesn't matter if user or machine e.g. C:\BAR that doesn't exist
  3. It puts files in C:\BAR without a subdirectory
  4. Download newer launcher
  5. It picks up C:\BAR
  6. It actually installs in C:\BAR\Beyond-All-Reason

This is a bug in upstream electron-updater used to create installer: electron-userland/electron-builder#6885. No known workarounds at this time.
@p2004a
Copy link
Collaborator Author

p2004a commented Jun 3, 2023

I've fixed it upstream: electron-userland/electron-builder#7552 now just waiting for the release of new version.

@p2004a p2004a self-assigned this Jun 3, 2023
@p2004a
Copy link
Collaborator Author

p2004a commented Jun 19, 2023

The version was released https://github.com/electron-userland/electron-builder/releases/tag/v24.5.0 need to update dependencies and test.

@p2004a
Copy link
Collaborator Author

p2004a commented Aug 5, 2023

Updated dependency in f1d71e4

@p2004a p2004a closed this as completed Aug 5, 2023
p2004a added a commit to p2004a/spring-launcher that referenced this issue Aug 5, 2023
@p2004a
Move files to new data folder on reinstall if hit electron bug
2c6e0a6 
beyond-all-reason#19 was
resolved, but there might be still installations affected by it. This
commit is a best effort fix for those people. Maybe it will reduce
support load we need to do for a few next weeks as people update.
@p2004a p2004a mentioned this issue Aug 6, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p2004a p2004a

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p2004a