fix(nsis): Ensure application name sub-folder on fresh installs. #7552
Conversation
During the first program install when the selected directory doesn't exist it's not enforced that path contains application name as sub-folder. On subsequent installs e.g. on update, that condition is enforces though, which creates a new installation in sub-folder. This tries to address electron-userland#6885
🦋 Changeset detectedLatest commit: 92e9c00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for car-park-attendant-cleat-11576 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@p2004a, thanks for the contribution! Just to confirm, how were you able to test this fix? Do you have a |
|
@mmaietta Sorry for slow response: I've tested it by applying the change locally in the Here is the behavior tested in Windows Sandbox: |
|
Looks great! But something about this makes me feel like it is a Breaking change? Something doesn't feel right to me about making this change. As it's deliberately reverting 958a7ae#diff-8a6dcd3ec142c996b1c93e06daa9cca068fb00476fbba98df6ce315afffb1a03 |
|
It's not reverting that change, but amending/fixing it. 958a7ae made sure that when user installs application in location of their choosing AND that location is non-empty, it's appending the That resolved #1298 because without that check, user could pick non-empty e.g. My change is dropping the "AND that location is non-empty" from the 958a7ae because guess what? When update happens, the previous install directory is non empty, so installer creates a new subdirectory. Is it a breaking change? In a way yes, but IMHO not really. Installation files on fresh install no longer will be directly in the user's chosen directory if it didn't exist, but a subdirectory with application name, but IMHO that's better then current behavior when reinstalling and updating just creates a second copy of application inside the previous install, potentially breaking install altogether. Much cleaner approach would be to somehow figure out whatever the selected directory with files in it is a existing previous install of the application, and if yes, allow installation in it without creating of the sub-directory. I'm personally not willing to learn NSIS scripting language and dive into this installer to implement it this way. |
|
Great explanation. LGTM |
During the first program install when the selected directory doesn't exist it's not enforced that path contains application name as sub-folder. On subsequent installs e.g. on update, that condition is enforces though, which creates a new installation in sub-folder.
This tries to address #6885