Limit shuffling of fieldset children #304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task: https://app.asana.com/0/1170776727341290/1175471955522877, https://app.asana.com/0/1170776727341290/1175281876558207
Test
Inputs we don't shuffle:
dont-mix
class set on it.Inputs we do want to shuffle:
Details
input[type=radio], input[type=checkbox]
selector because the inputs in the fieldset are actually wrapped in<div>s
to accommodate things like inline feedback, etc., so we are dependent on these specific classnames being in the HTML