Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add php 8 support #14

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Add php 8 support #14

merged 1 commit into from
Apr 12, 2021

Conversation

lasseeee
Copy link
Contributor

@lasseeee lasseeee commented Dec 5, 2020

No description provided.

@lasseeee lasseeee mentioned this pull request Dec 5, 2020
@octoper
Copy link

octoper commented Dec 10, 2020

@lasseeee waiting for Laravel Zero to add support for PHP 8 laravel-zero/framework#421 and you will need to update to latest laravel-zero/framework too when it will be available.

@owenvoke
Copy link

Just a heads up, Laravel Zero v8.4.0 has now been released with support for PHP 8. 👍🏻

@lahivee
Copy link

lahivee commented Dec 26, 2020

There should be a service where you can donate to "push" for a pending version upgrade PR to get merged :D

cc @mpociot 1. as a reminder (because I think this notifications can slip through) and 2. as an idea for another project 👀

@Iamscaredofcode
Copy link

can this be merged, or what are we waiting for here?

@octoper
Copy link

octoper commented Jan 6, 2021

I think he will need to change the version of laravel-zero/framework from 8.0 to 8.5 and it will be ready to merge

cc @lasseeee

@lasseeee
Copy link
Contributor Author

lasseeee commented Jan 6, 2021

laravel-zero/framework is required at ^8.0 and should pick up the minor release where PHP 8.0 support was added (v8.4) without any change to the pull request, or am I mistaken?

@lahivee
Copy link

lahivee commented Jan 6, 2021

yea actually think so too. Does composer install cause any errors with fresh composer.lock file? If not then we are good to go

@lahivee
Copy link

lahivee commented Jan 6, 2021

Anyways, I think bumping the version quickly to v8.4 would be 'the right' thing to do @lasseeee

@mpociot mpociot merged commit c2f30fb into beyondcode:master Apr 12, 2021
@mpociot
Copy link
Member

mpociot commented Apr 12, 2021

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants