Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update to support PHP 8 #421

Merged
merged 11 commits into from
Dec 21, 2020
Merged

feat: update to support PHP 8 #421

merged 11 commits into from
Dec 21, 2020

Conversation

owenvoke
Copy link
Member

@owenvoke owenvoke commented Nov 3, 2020

It looks like the following also need to be updated to support PHP 8 upstream.

We will also want to update the Updater component to use the new Laravel Zero fork of PHAR Updater.

composer.json Outdated Show resolved Hide resolved
@nunomaduro
Copy link
Member

cc @owenvoke

@owenvoke
Copy link
Member Author

owenvoke commented Dec 2, 2020

@hmazter, is there any chance you could tag a release of Laravel Schedule List with PHP 8 support? 🙂

@hmazter
Copy link

hmazter commented Dec 2, 2020

@hmazter, is there any chance you could tag a release of Laravel Schedule List with PHP 8 support? 🙂

Sorry, thought that I already had. Will fix it in 2 hours. 😄

@owenvoke
Copy link
Member Author

owenvoke commented Dec 2, 2020

No problem, thank you!

@hmazter
Copy link

hmazter commented Dec 2, 2020

@hmazter, is there any chance you could tag a release of Laravel Schedule List with PHP 8 support? 🙂

Sorry, thought that I already had. Will fix it in 2 hours. 😄

v2.2.1 tagged https://packagist.org/packages/hmazter/laravel-schedule-list#v2.2.1

@nunomaduro
Copy link
Member

@owenvoke Let me know If I can help here.

@owenvoke
Copy link
Member Author

owenvoke commented Dec 2, 2020

I think Box is the only thing we are waiting on now. 👍 I'm going to have a check through the internal framework code to check that's all compatible as well.

@nunomaduro
Copy link
Member

We should be good on that regard, as we have some tests. And if something is not good, the community can report and we patch it. So we need to wait for box now...

@owenvoke
Copy link
Member Author

Right, Box v3.11.0 is now released which adds PHP 8 support. I will add this in and try to aim for a release soon. 👍

@owenvoke owenvoke marked this pull request as ready for review December 18, 2020 16:34
@owenvoke owenvoke merged commit c2ce7b0 into master Dec 21, 2020
@owenvoke owenvoke deleted the feature/php-8 branch December 21, 2020 09:53
@bhamail
Copy link

bhamail commented Feb 16, 2021

Is this perhaps another dependency that needs to be updated for php8?:

intonate/tinker-zero

see: "php": "^7.2.5"

With a dependency on "laravel-zero/framework": "^8.0" (and "php": "^8.0",), I get the following composer update error:

Your requirements could not be resolved to an installable set of packages.

  Problem 1
    - intonate/tinker-zero[dev-master, v1.1.0] require php ^7.2.5 -> your php version (8.0.0) does not satisfy that requirement.
    - Root composer.json requires intonate/tinker-zero >1.0 -> satisfiable by intonate/tinker-zero[v1.1.0].

@owenvoke owenvoke restored the feature/php-8 branch February 16, 2021 18:13
@owenvoke owenvoke deleted the feature/php-8 branch February 16, 2021 18:13
@owenvoke
Copy link
Member Author

@bhamail, Tinker Zero isn't an official package so they'd have to add support over there. Feel free to open a PR on their repository, or I'll PR it tomorrow.

@bhamail
Copy link

bhamail commented Feb 16, 2021

@owenvoke Cool. Thanks!

Just in case others hit a similar issue, in my case, we don't need tinker-zero in php8, so removing it was fine, until I forgot to remove the providers entry. See: sonatype-nexus-community/bach@f491d71

@owenvoke
Copy link
Member Author

I've opened a PR over at intonate/tinker-zero#8, so hopefully that can get merged. 👍🏻

Anyway, glad you got it sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants