Fix the PHP version check with the use of Semver #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current check only takes the PHP version from the composer.json file and checks if the current version is the same or higher. But composer has more options, that if used can be conflicted or incorrect tested. See: https://getcomposer.org/doc/articles/versions.md#summary
I have changed the behaviour by using the Semver package from composer to check it.
The only question I have is the change on the getRequiredPhpVersion function. Because it is a public function I didn't want to change it and added a new function getRequiredPhpConstraint. That means that there is now a function that isn't used by the check. If wanted I can mark it as deprecated