tweak(tupaiaWeb): RN-1088 Description in Export Preview & Download File #5905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexd-bes
requested changes
Sep 18, 2024
packages/tupaia-web/src/features/Dashboard/ExportDashboard/ExportDashboard.tsx
Outdated
Show resolved
Hide resolved
packages/tupaia-web/src/features/ExportSettings/ExportDescriptionInput.tsx
Outdated
Show resolved
Hide resolved
packages/tupaia-web/src/features/ExportSettings/ExportDescriptionInput.tsx
Outdated
Show resolved
Hide resolved
packages/tupaia-web/src/features/ExportSettings/ExportDescriptionInput.tsx
Outdated
Show resolved
Hide resolved
packages/tupaia-web/src/features/ExportSettings/ExportDescriptionInput.tsx
Outdated
Show resolved
Hide resolved
packages/tupaia-web/src/features/ExportSettings/ExportDescriptionInput.tsx
Outdated
Show resolved
Hide resolved
packages/tupaia-web/src/features/ExportSettings/ExportDescriptionInput.tsx
Show resolved
Hide resolved
packages/tupaia-web/src/features/PDFExportDashboardItem/PDFExportDashboardItem.tsx
Outdated
Show resolved
Hide resolved
packages/tupaia-web/src/features/PDFExportDashboardItem/PDFExportDashboardItem.tsx
Outdated
Show resolved
Hide resolved
| <PDFExportDashboardItem | ||
| key={dashboardItem.code} | ||
| dashboardItem={dashboardItem} | ||
| entityName={entity?.name} | ||
| activeDashboard={activeDashboard} | ||
| isPreview={isPreview} | ||
| settings={settings} | ||
| displayDescription={pageIndex === 1 || (!isPreview && i === 0)} |
There was a problem hiding this comment.
Currently (although this is due to change) there is 1 visual per page, so as long as i===0 this should always be the same as being the first page.
Once we merge in the other ticket that I worked on with continuous pages, you can amend this.
alexd-bes
approved these changes
Sep 24, 2024
|
|
||
| const Wrapper = styled.div` | ||
| display: flex; | ||
| flex-direction: column; | ||
| `; | ||
|
|
||
| const ExportDescriptionInputArea = styled(TextField)` | ||
| const ExportDescriptionInputArea = styled((props: OutlinedTextFieldProps) => ( | ||
| <TextField {...props} /> |
There was a problem hiding this comment.
Out of interest, is there any reason you need to do this instead of styled(TextField)?
There was a problem hiding this comment.
Oh yes, because it was defaulting to OutlinedTextFieldProps which wasn't allowing me to configure variant='outline'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: RN-1088
Changes:
Screenshots: