CMake support #131

Closed
MikeMcQuaid opened this Issue Sep 16, 2010 · 12 comments

Comments

Projects
None yet
3 participants

Ack should support reading CMakeLists.txt files.

Would a patch for this be accepted?

Collaborator

petdance commented Sep 16, 2010

Would it be --cmake or lumped in with --make? I think the latter would be better.

I'd say it should be --cmake as it is it's own language and when using a CMake buildsystem I'd want to disable --make and enable --cmake as the Makefiles are generated and therefore no longer interesting to me.

nhooey commented Sep 16, 2010

I'm guessing petdance will say that this won't be implemented until Ack 2.0.

It should be a very easy fix, just searching based on filenames. It would be good to get it in before 2.0, if possible.

Any more thoughts on this? Just adding the search to .txt files works in the meantime but it would be great to be able to search only files named CMakeLists.txt. I tried to do it myself but my perl-foo isn't strong. I could maybe manage with some pointers.

nhooey commented Oct 6, 2010

I'm considering forking ack to add many of the patches that petdance says he won't bother with until version 2.0. Stay tuned, and I'll notify you if I do this. Then we can add your feature.

Collaborator

petdance commented Oct 6, 2010

How about you talk to me/us on the mailing list before going down the fork road, Neil?

nhooey commented Oct 6, 2010

I had the impression that you weren't going to implement any new features until Ack 2.0.

I put in a pull request, complete with tests, that nobody has looked at, and there's a patch for files without extensions.

Could you have a look at those?

Collaborator

petdance commented Oct 6, 2010

Post to the list and let's see what the accumulated readership thinks. When we're talking about changing stuff as potentially disruptive as file selection, I want to get public eyeballs on it.

Collaborator

petdance commented Oct 6, 2010

Also, your link to that pull request is broken.

nhooey commented Oct 6, 2010

The link is fixed now.

I'll post to the mailing list.

Collaborator

petdance commented Apr 27, 2013

cmake has been added to ack 2.

@petdance petdance closed this Apr 27, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment