Close/Flush Storage stream when cancel requested. #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents cases where the file handle will be let go before writing the buffer.
|
Thank you for reporting this issue, but this pull request has some issue with MemoryStorages. I'll fix this problem and release the new version |
|
No worries, thanks for responding so quickly. It might be worth looking into tests that restart the application, but I'm not sure how possible that is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents cases where the file handle will be let go before writing the part-full buffer.
I discovered this when serialising the Package to disk and attempting to resume downloads after an application restart, the Chunks were missing data preventing the resume.