-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: multi-stage image build #831
fix: multi-stage image build #831
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestion about copying only the binary and nothing else.
Otherwise the image size will be bloated for things that we are not interested with.
Thanks @machi1990 I'll change that now |
…building the binary on the host
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VanillaSpoon thanks for the PR.
Code change looks good to me.
What steps (commands) would you advise someone take to quickly verify the change locally?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for this @VanillaSpoon! just one question there :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
let's wait for @JameelB thumbs up on the question before merging.
Thanks a lot for the great shift on this as well as going the extra step in verifying it. @VanillaSpoon
Also upgrade the required go version to 1.17 to fix reported CVEs on 1.16 This applys the bf2fc6cc711aee1a0c2a/kas-fleet-manager#873 and bf2fc6cc711aee1a0c2a/kas-fleet-manager#831 PRs which were done in kas-fleet-manager
Use a multi-stage image build for kas-fleet-manager rather than building the binary on the host
Description
Configured a multi-stage image build rather than building the binary on the host. This reduces broken images from incompatible dependencies.
Issue: https://issues.redhat.com/secure/RapidBoard.jspa?rapidView=8806&view=detail&selectedIssue=MGDSTRM-5007&quickFilter=48314
Checklist (Definition of Done)
Documentation added for the featureRequired Standard Operating Procedure (SOP) is added.JIRA has created for changes required on the client side