[MGDSTRM-10036] Add bf2_org_kafkaInstanceProfileType to Kafka instance metrics #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… metrics ZookeeperContainersDown and KafkaBrokerContainersDown alerts rely on this label which is set on 'kafka_brokers' metric emitted from Kafka. However, if kafka containers are not running, this metric dissappear. In this situation, the alerts never trigger which is counter to their purpose of alerting when containers are not running. Instead of 'kafka_brokers', the alerts can use kafka instance metrics emitted from fleetshard so that it doesn't rely on kafka itself.
tinaselenge
changed the title
k-wall
reviewed
Nov 15, 2022
k-wall
approved these changes
Nov 15, 2022
Shorten the label for consistency
MikeEdgar
approved these changes
Nov 15, 2022
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.redhat.com/browse/MGDSTRM-10036
ZookeeperContainersDown and KafkaBrokerContainersDown alerts rely on this label which is set on 'kafka_brokers' metric emitted from Kafka. However, if kafka containers are not running, this metric disappear. In this situation, the alerts never trigger which is counter to their purpose of alerting when containers are not running.
Instead of 'kafka_brokers', the alerts can use Kafka instance metrics emitted from kas-fleetshard so that it doesn't rely on Kafka itself.
