Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add HTTP/2 fingerprint support #1072

Merged
merged 7 commits into from
Sep 13, 2022
Merged

Conversation

xqbumu
Copy link
Contributor

@xqbumu xqbumu commented Aug 22, 2022

resolve #1071

@CLAassistant
Copy link

CLAassistant commented Aug 24, 2022

CLA assistant check
All committers have signed the CLA.

bfe_tls/common.go Outdated Show resolved Hide resolved
bfe_http/request.go Outdated Show resolved Hide resolved
bfe_http2/server.go Outdated Show resolved Hide resolved
bfe_http2/fingerprint.go Outdated Show resolved Hide resolved
bfe_http2/fingerprint.go Outdated Show resolved Hide resolved
bfe_http2/fingerprint.go Outdated Show resolved Hide resolved
bfe_http2/fingerprint.go Outdated Show resolved Hide resolved
bfe_http2/fingerprint.go Outdated Show resolved Hide resolved
bfe_http2/fingerprint_test.go Show resolved Hide resolved
Signed-off-by: xqbumu <xqbumu@163.com>
Signed-off-by: xqbumu <xqbumu@163.com>
Signed-off-by: xqbumu <xqbumu@163.com>
Signed-off-by: xqbumu <xqbumu@163.com>
Signed-off-by: xqbumu <xqbumu@163.com>
Signed-off-by: xqbumu <xqbumu@163.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2022

Codecov Report

Merging #1072 (8bc4a64) into develop (4f81511) will increase coverage by 0.12%.
The diff coverage is 95.83%.

@@             Coverage Diff             @@
##           develop    #1072      +/-   ##
===========================================
+ Coverage    54.25%   54.37%   +0.12%     
===========================================
  Files          301      302       +1     
  Lines        26602    26698      +96     
===========================================
+ Hits         14432    14518      +86     
- Misses       10509    10515       +6     
- Partials      1661     1665       +4     
Impacted Files Coverage Δ
bfe_http/request.go 70.89% <ø> (ø)
bfe_modules/mod_header/action_header_var.go 0.00% <0.00%> (ø)
bfe_http2/fingerprint.go 97.80% <97.80%> (ø)
bfe_http2/server.go 72.42% <100.00%> (-0.10%) ⬇️
bfe_http2/writesched.go 79.38% <0.00%> (-1.53%) ⬇️
bfe_websocket/server_conn.go 72.72% <0.00%> (-1.52%) ⬇️
bfe_spdy/frame_write.go 50.50% <0.00%> (ø)
bfe_spdy/server_conn.go 78.53% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kwanhur
Copy link
Contributor

kwanhur commented Aug 30, 2022

Please do not force-push, we leave those commits for review history, other reviewers get benefits from them.

bfe_http2/fingerprint.go Show resolved Hide resolved
bfe_http2/fingerprint.go Outdated Show resolved Hide resolved
bfe_http2/fingerprint.go Outdated Show resolved Hide resolved
bfe_http2/fingerprint.go Show resolved Hide resolved
@xqbumu xqbumu requested a review from iyangsj September 13, 2022 03:43
@iyangsj iyangsj merged commit 6b0de42 into bfenetworks:develop Sep 13, 2022
clarinette9 pushed a commit to clarinette9/bfe that referenced this pull request Oct 27, 2022
Signed-off-by: xqbumu <xqbumu@163.com>
Signed-off-by: clarinette9 <songjiansuperman@163.com>
supermario1990 pushed a commit to supermario1990/bfe that referenced this pull request Feb 20, 2024
Signed-off-by: xqbumu <xqbumu@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Support HTTP2 fingerprint
5 participants