Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Versioned Clang automatic configuration #1

Conversation

Kojoley
Copy link
Contributor

@Kojoley Kojoley commented Mar 5, 2021

Currently, without annoying toolset.using directives in user-config.jam, b2 toolset=clang-xx silently uses clang++ binary, even if it is a different version than requested. Instead of copycating GCC or reinventing a wheel I have generalized GCC automatic configuration and used it for Clang.

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other (please describe):

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I searched the discussions
  • I searched the closed and open issues
  • I read the contribution guidelines
  • I added myself to the copyright attributions for significant changes
  • I checked that tests pass locally with my changes
  • I added tests that prove my fix is effective or that my feature works
  • I added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

Kojoley and others added 7 commits April 20, 2021 21:37
Currently, without annoying `toolset.using` directives in `user-config.jam`, `b2 toolset=clang-xx` silently uses clang++ binary, even if it is a different version than requested. Instead of copycating GCC or reinventing a wheel I have generalized GCC automatic configuration and used it for Clang.
@Kojoley Kojoley force-pushed the feature/versioned-clang-automatic-configuration branch from b7d9d70 to 9121e86 Compare April 20, 2021 18:37
@Kojoley
Copy link
Contributor Author

Kojoley commented Apr 22, 2021

@grafikrobot is there anything stopping the PR from being merged?

@grafikrobot grafikrobot merged commit 9552adf into bfgroup:main Apr 23, 2021
@Kojoley Kojoley deleted the feature/versioned-clang-automatic-configuration branch April 24, 2021 00:01
@Kojoley Kojoley mentioned this pull request May 6, 2021
@diehlpk diehlpk mentioned this pull request Sep 24, 2021
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants