Refactor RunPage to detangle emulator #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows embedding just the emulator as a React component by passing ROM data as a string to Emulator. It handles writing to canvas, sound, keyboard events, mouse events, etc etc. Minimal viable emulator: ```javascript <Emulator romData="..." /> ``` Boom. There is still some refactoring to do to clean up keyboard/gamepad customisation. See also #149. Also, to make this work we need to release jsnes-web as a package on npm and document how to embed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows embedding just the emulator as a React component by
passing ROM data as a string to Emulator. It handles writing to
canvas, sound, keyboard events, mouse events, etc etc.
Minimal viable emulator:
Boom.
There is still some refactoring to do to clean up keyboard/gamepad
customisation. See also #149.
Also, to make this work we need to release jsnes-web as a package
on npm and document how to embed it.