Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor RunPage to detangle emulator #170

Merged
merged 2 commits into from
Jan 20, 2019
Merged

Refactor RunPage to detangle emulator #170

merged 2 commits into from
Jan 20, 2019

Commits on Jan 16, 2019

  1. Refactor RunPage to detangle emulator 

    This allows embedding just the emulator as a React component by
passing ROM data as a string to Emulator. It handles writing to
canvas, sound, keyboard events, mouse events, etc etc.

Minimal viable emulator:

```javascript
<Emulator romData="..." />
```

Boom.

There is still some refactoring to do to clean up keyboard/gamepad
customisation. See also #149.

Also, to make this work we need to release jsnes-web as a package
on npm and document how to embed it.
    @bfirsh
    bfirsh committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    f34f3a4 View commit details
    Browse the repository at this point in the history

  2. Fix typescript errors

    @bfirsh
    bfirsh committed Jan 16, 2019
    Configuration menu
    Copy the full SHA
    c8bd71e View commit details
    Browse the repository at this point in the history