Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compat: don't build when strlcpy is present #47

Merged
merged 1 commit into from
Aug 19, 2021

Conversation

alebcay
Copy link
Contributor

@alebcay alebcay commented Aug 19, 2021

In environments where strlcpy is present, an attempt will be made to build libcompat.la, but libcompat will have no sources because of the conditional in compat/Makefile.am. As such the build will fail because ar is trying to create an archive without any sources passed to it.

Instead, move the conditional check to the top-level Makefile.am, such that strlcpy.lo is not built and also libcompat.la is ignored entirely.

@job job merged commit af202a8 into bgp:main Aug 19, 2021
@job
Copy link
Member

job commented Aug 19, 2021

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants