Relation to KeepaliveTime and other nits
#2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me |
cjeker
reviewed
Mar 25, 2024
| @@ -231,7 +231,7 @@ | |||
|
|
|||
| <section title="Changes to BGP Timers"> | |||
| <t>In Section 10 of <xref target="RFC4271"/> summarizes BGP Timers. This document adds another BGP timer: SendHoldTimer.</t> | |||
| <t>SendHoldTime is a mandatory FSM attribute that stores the initial value for the SendHoldTimer. The suggested default value for SendHoldTime is 8 minutes. An implementation MAY make it configurable.</t> | |||
| <t>SendHoldTime is a mandatory FSM attribute that stores the initial value for the SendHoldTimer. SendHoldTime MUST be greater than the value of KeepaliveTime. The suggested default value for SendHoldTime is the greater of 8 minutes or 6 times KeepaliveTime. An implementation MAY make it configurable.</t> | |||
There was a problem hiding this comment.
I would prefer if this would use HoldTime instead of KeepaliveTime. The HoldTime is negotiated while KeepaliveTime is more implementation specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SendHoldTimebe greater thanKeepAliveTime