Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Relation to KeepaliveTime and other nits #2

Merged
merged 3 commits into from Mar 24, 2024
Merged

Relation to KeepaliveTime and other nits #2

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab7a299
require `SendHoldTime` be greater than `KeepAliveTime`
benmaddison Mar 24, 2024
0fddc15
nits
benmaddison Mar 24, 2024
3f69dff
correct capitalisation
benmaddison Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
16 changes: 8 additions & 8 deletions draft-ietf-idr-bgp-sendholdtimer.xml
View file
Open in desktop
Expand Up @@ -71,7 +71,7 @@
<abstract>

<t>
This document defines the SendHoldtimer and the SendHoldTimer Expired events for the Border Gateway Protocol (BGP) Finite State Machine (FSM).
This document defines the SendHoldtimer, along with the SendHoldTimer_Expires event, for the Border Gateway Protocol (BGP) Finite State Machine (FSM).
Implementation of the SendHoldTimer helps overcome situations where a BGP session is not terminated after the local system detects that the remote system is not processing BGP messages.
This document specifies that the local system should close the BGP connection and not solely rely on the remote system for session closure when the SendHoldTimer expires.
This document updates RFC4271.
Expand All @@ -92,16 +92,16 @@
<section title="Introduction">

<t>
This document defines the SendHoldtimer and the SendHoldTimer Expired events for the Border Gateway Protocol (BGP) <xref target="RFC4271" /> Finite State Machine (FSM) defined in section 8.
This document defines the SendHoldtimer, along with the SendHoldTimer_Expires event, for the Border Gateway Protocol (BGP) <xref target="RFC4271" /> Finite State Machine (FSM) defined in section 8.
</t>

<t>
Failure to terminate a blocked BGP session can result in Denial Of Service, and the subsequent failure to generate and deliver BGP WITHDRAW and UPDATE messages to other BGP peers of the local system is detrimental to all participants of the inter-domain routing system.
This phenomena is theorized to have contributed to IP traffic blackholing events in global Internet routing system <xref target="bgpzombies"/>.
This phenomena is thought to have contributed to IP traffic blackholing events in the global Internet routing system <xref target="bgpzombies"/>.
</t>
<t>
This specification intends to improve this situation by requiring sessions to be terminated if the local system has detected that the remote system cannot possibly have received any BGP messages for the duration of the SendHoldTime.
Through codification of the aforementioned requirement, operators will benefit from consistent behavior across different BGP implementations.
This specification intends to improve this situation by requiring that sessions be terminated if the local system has detected that the remote system cannot possibly have processed any BGP messages for the duration of the SendHoldTime.
Through standardisation of the aforementioned requirement, operators will benefit from consistent behavior across different BGP implementations.
</t>
<t>
BGP speakers following this specification do not exclusively rely on remote systems closing blocked connections, but will also locally close connections.
Expand Down Expand Up @@ -154,7 +154,7 @@
9) SendHoldTimer
</t>
<t>
10) SendHoldTime (an initial value of 8 minutes is recommended)
10) SendHoldTime
</t>
</list>
</t>
Expand Down Expand Up @@ -201,7 +201,7 @@
(Event 26)), the local system:
<list style="hanging">
<t hangText="-">restarts the HoldTimer,</t>
<t hangText="-">sets the SendHoldTimer to the default or configured value, and</t>
<t hangText="-">sets the SendHoldTimer to the default or configured value of SendHoldTime, and</t>
<t hangText="-">changes its state to Established.</t>
</list></t>
</dd>
Expand Down Expand Up @@ -231,7 +231,7 @@

<section title="Changes to BGP Timers">
<t>In Section 10 of <xref target="RFC4271"/> summarizes BGP Timers. This document adds another BGP timer: SendHoldTimer.</t>
<t>SendHoldTime is a mandatory FSM attribute that stores the initial value for the SendHoldTimer. The suggested default value for SendHoldTime is 8 minutes. An implementation MAY make it configurable.</t>
<t>SendHoldTime is a mandatory FSM attribute that stores the initial value for the SendHoldTimer. SendHoldTime MUST be greater than the value of KeepaliveTime. The suggested default value for SendHoldTime is the greater of 8 minutes or 6 times KeepaliveTime. An implementation MAY make it configurable.</t>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if this would use HoldTime instead of KeepaliveTime. The HoldTime is negotiated while KeepaliveTime is more implementation specific.

</section>

</section>
Expand Down