Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code test coverage to 90% #147

Merged
merged 20 commits into from
Jan 3, 2024
Merged

Code test coverage to 90% #147

merged 20 commits into from
Jan 3, 2024

Conversation

digizeph
Copy link
Member

@digizeph digizeph commented Dec 22, 2023

Goal

Code test coverage to 90%.

Progress

  • models
    • network
    • mrt
    • bgp
  • encoder
  • parser
    • filter
    • iters
    • utils
    • mrt
    • bmp
    • bgp
    • rislive

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 20 lines in your changes are missing coverage. Please review.

Comparison is base (012ecea) 68.77% compared to head (1bc0f4e) 91.97%.

Files Patch % Lines
src/parser/mrt/messages/table_dump.rs 90.00% 6 Missing ⚠️
.../bgp/attributes/attr_16_25_extended_communities.rs 94.28% 2 Missing ⚠️
src/parser/bmp/messages/route_mirroring.rs 95.55% 2 Missing ⚠️
src/parser/bmp/messages/stats_report.rs 94.11% 2 Missing ⚠️
src/parser/bgp/attributes/attr_14_15_nlri.rs 98.27% 1 Missing ⚠️
src/parser/bgp/messages.rs 99.16% 1 Missing ⚠️
src/parser/bmp/messages/headers.rs 98.71% 1 Missing ⚠️
src/parser/bmp/messages/initiation_message.rs 96.96% 1 Missing ⚠️
src/parser/bmp/messages/peer_up_notification.rs 97.91% 1 Missing ⚠️
src/parser/bmp/messages/termination_message.rs 96.87% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #147       +/-   ##
===========================================
+ Coverage   68.77%   91.97%   +23.19%     
===========================================
  Files          72       67        -5     
  Lines        6691     9006     +2315     
===========================================
+ Hits         4602     8283     +3681     
+ Misses       2089      723     -1366     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@digizeph digizeph changed the title Expanding tests coverage Code test coverage to 100% Dec 22, 2023
@digizeph digizeph added this to the V1.0.0 milestone Dec 23, 2023
@digizeph digizeph changed the title Code test coverage to 100% Code test coverage to 90% Dec 24, 2023
@digizeph digizeph merged commit a413b50 into main Jan 3, 2024
5 checks passed
@digizeph digizeph deleted the test-coverage branch January 3, 2024 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant