Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build fails for r-bipartitemodularitymaximization #59

Closed
ezherman opened this issue Apr 7, 2023 · 5 comments
Closed

Windows build fails for r-bipartitemodularitymaximization #59

ezherman opened this issue Apr 7, 2023 · 5 comments

Comments

@ezherman
Copy link

ezherman commented Apr 7, 2023

Hi, thank you for creating this resource! I tried following the instructions to get the R package BipartiteModularityMaximization onto conda-forge. However, the windows build failed (see conda-forge/staged-recipes#22460). I am sadly out of my depth here - would you be able to provide any thoughts on how I could fix this failure? I did not develop the R package, I'm only using it in one of my workflows.

Thanks in advance!

@bgruening
Copy link
Owner

@ezherman I don't have a windows machine available to debug. The recipe looks good to me. Maybe there are some quirks that you need to do to compile it on windows. Sorry, but maybe its better to ask for help in your conda-forge PR and ping the r-team or windows team there.

@jdblischak
Copy link
Collaborator

Agreed with @bgruening. Issues in this repository are to report any problems in the generated recipe, particularly if the linter fails. In this case, everything looks fine.

Unfortunately more complex packages need additional troubleshooting that can't be anticipated beforehand, especially for packages that require compilation. This discussion takes place on the staged-recipes PR itself. I reviewed the Windows build log and commented on your PR with some advice on what to try next.

@bgruening
Copy link
Owner

Thanks @jdblischak!

@mfansler
Copy link
Contributor

FYI, there is a global recipe patch suggested, just hasn't merged yet: conda/conda-build#4786

Basically, Conda Forge has gotten stricter in testing linked libraries, and since the R.dll is in an atypical location it isn't picked up correctly. We might want to consider adding the patch here in the meantime to alleviate confusion on new submissions.

@cmkobel
Copy link

cmkobel commented May 2, 2024

I'm having the exact same problem, I think. conda-forge/staged-recipes#26190

Could anyone direct me on a workaround until the patch that @mfansler mentions is implemented?


Technical info:
"ERROR (r-chnosz,lib/R/library/CHNOSZ/libs/x64/CHNOSZ.dll): $RPATH/R.dll not found in packages, sysroot(s) nor the missing_dso_whitelist."

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=924527&view=logs&j=240f1fee-52bc-5498-a14a-8361bde76ba0&t=7c0f8eae-6d6f-51bf-636f-73a1a7fb1bc4&l=1747


Update: The workaround is to add

  missing_dso_whitelist:
    - '*/R.dll'                        # [win]

under the "build:" key.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants