Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

antismash5 #1015

Merged
merged 6 commits into from Aug 9, 2020
Merged

antismash5 #1015

merged 6 commits into from Aug 9, 2020

Conversation

bgruening
Copy link
Owner

No description provided.

@bgruening
Copy link
Owner Author

@abretaud is there any interest to update this wrapper? Do you follow the latest updates of Antismash? What is fungismash? So many questions :)

@abretaud
Copy link
Collaborator

abretaud commented Jul 8, 2020

Hello!
There is probably interest, but not particularly from me as I don't use it :) So no, I'm not following the updates, but we can merge this one I guess as long as the tests pass
I would say fungismash is the antismash of fungi (antismash being for bacteria), but I don't know more than that

@abretaud
Copy link
Collaborator

abretaud commented Jul 8, 2020

ah, antismash was in tt_skip, I just removed it to see what it does

@simonbray
Copy link
Collaborator

Maybe I can (should?) adopt this wrapper?

@bgruening
Copy link
Owner Author

@simonbray all help is welcome. I upgraded the wrapper, but I can not test. For whatever reason, every install fails to download the databases ... :(

@bgruening
Copy link
Owner Author

Ok, in the Container that I build it is running and test pass locally. I guess this is a travis issue as during installation 4Gb will be downloaded and several indices will be installed, e.g. via Diamond.

@bgruening bgruening merged commit 19cbd26 into master Aug 9, 2020
@bgruening bgruening deleted the antismash5 branch August 9, 2020 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants