New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rna_tools: Add DoRiNA data source tool definition. #123
Conversation
Add a basic data source tool definition for the public DoRiNA deployment. When accessed with a GALAXY_URL parametre, DoRiNA offers a link back to the provided Galaxy instance enabling it to fetch the results in tabular form.
@rekado thanks a lot! |
Isn't this part of any Galaxy deployment? I did not write the code in |
@bgruening is correct - it needs to live beside the tool. If you look at the tools in Galaxy they are all in folders that also contain |
Okay then. I'll add |
@rekado thank you a lot 👍 I'm very glad you did this so quickly. I hope the de.NBI members will take notice 😏 |
I added I could not find any license headers on (Do you want me to add license headers to |
@rekakdo the file located at tools/data_source/data_source.py in the Galaxy distribution is Academic Free License version 3.0: https://raw.githubusercontent.com/galaxyproject/galaxy/dev/LICENSE.txt Although, ideally, we should probably build a separate dependency package containing this python script and attempt to decouple it from the Galaxy code as much as possible. I wouldn't consider that a blocker at this point, however. |
Also, I do not think you need to add that license to the xml, the xml doesn't contain any part of the dorina code. |
Well, as the author of dorina.xml I can publish it under dual licenses to make it possible to combine it with the AFL3.0 in the context of Galaxy and with my preferred license, the GPLv3+, so this is not an insurmountable problem :) |
@blankenberg is it ok for you to put |
I have nothing more to add. The last commit adds license notes for both files in a separate LICENSE file, indicating that for the XML file a license exception to combine with Galaxy is granted. (AFL and GPL are not compatible, unfortunately, so I had to make this dual-licensing explicit.) |
rna_tools: Add DoRiNA data source tool definition.
Great! Thanks a lot! |
Add a basic data source tool definition for the public DoRiNA
deployment. When accessed with a GALAXY_URL parametre, DoRiNA offers a
link back to the provided Galaxy instance enabling it to fetch the
results in tabular form.