Add netboxr tool (beta version) - second attempt #1230
Conversation
| @@ -0,0 +1,5 @@ | |||
| categories: [] | |||
There was a problem hiding this comment.
you need to pick one from https://toolshed.g2.bx.psu.edu/
| @@ -0,0 +1,5 @@ | |||
| categories: [] | |||
| description: netboxr_tool | |||
There was a problem hiding this comment.
better description would be nice :)
| @@ -0,0 +1,182 @@ | |||
| <tool id="netboxr_tool" name="NetBox" version="1.6.0"> | |||
There was a problem hiding this comment.
I would remove the _tool from the ID
| <requirement type="package">r-optparse</requirement> | ||
| <requirement type="package" version="1.6.0">bioconductor-netboxr</requirement> | ||
| </requirements> | ||
| <stdio> |
There was a problem hiding this comment.
remove stdio and use detect_errors see https://docs.galaxyproject.org/en/latest/dev/schema.html#error-detection
| after you make pull request--> | ||
| </command> | ||
| <inputs> | ||
| <param name="gene_list" type="data" format=".txt" label="Gene list" help="A |
There was a problem hiding this comment.
can you follow maybe the IUC formatting of XML files to make it more readable?
| <inputs> | ||
| <param name="gene_list" type="data" format=".txt" label="Gene list" help="A | ||
| newline-delimited text file that contains a list of genes of interest"/> | ||
| <param name="cutoff" type="text" label="P-Value Cut-Off" |
There was a problem hiding this comment.
that looks like type="float" and you can set a value="0.05"
|
@bgruening Thanks for the feedback! |
|
@sajo25 anything we can help here? |
|
@bgruening I made the requested changes and created another PR. My understanding is that this PR needs to be merged, after which the tool will automatically be uploaded to the ToolShed. Is that right, or am I missing something? |
|
Ah didn't saw the new one, thanks. |
Changes made based on results from automated tests.