Reworks the balance checks and adds them for erc721 tokens #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
schmanu
commented
Jan 7, 2022
schmanu
commented
- Instead of using the web3provider to check individual token balances we fetch all balances at the start of the app
- Adds balance and duplicate ID check for ERC721 transfers
- Also adds a Warning if there are more than 400 lines of transfers (and doesn't parse the file then)
- Instead of using the web3provider to check individual token balances we fetch all balances at the start of the app - Adds balance and duplicate ID check for ERC721 transfers
* The link to the sample file was moved into the Help-Modal * Instead there is a menu to generate transfers with the option to drain the safe closes #171
bh2smith
approved these changes
Jan 8, 2022
Comment on lines
+44
to
+46
| collectibleBalance?.forEach((collectible) => { | ||
| drainCSV += `\nnft,${collectible.address},${drainAddress},,${collectible.id}`; | ||
| }); |
There was a problem hiding this comment.
Wow! Even NFTs! Sexy! This is probably better than the existing drain safe app.
There was a problem hiding this comment.
If we drain we leave no stain!
src/utils.ts
Outdated
| if (typeof tokenSummary === "undefined") { | ||
| tokenSummary = { | ||
| tokenAddress: currentValue.tokenAddress, | ||
| amount: 0, // We track the amount to detect duplicate ids |
There was a problem hiding this comment.
Maybe it would be better to use 'count' here. Amount seems "fungible"
* 100% test coverage of asset and collectible balance check
* the csvParser covers the max-line check * test for the max-line check
bh2smith
approved these changes
Jan 9, 2022
* a boolean flag for duplicate transfers instead of transferAmount * test for duplicate transfer detection
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.